Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PBKDF2 #102

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Support PBKDF2 #102

merged 3 commits into from
Aug 17, 2023

Conversation

qmuntal
Copy link
Collaborator

@qmuntal qmuntal commented Aug 10, 2023

All OpenSSL versions supports PKCS5_PBKDF2_HMAC and, fortunately, it has the same parameters as x/crypto/pbkdf2.Key.

ueno
ueno approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

derekparker
derekparker approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qmuntal qmuntal merged commit b95716c into v2 Aug 17, 2023
10 checks passed
@qmuntal qmuntal deleted the pbkdf2 branch August 17, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueno ueno ueno approved these changes

@derekparker derekparker derekparker approved these changes

@jaredpar jaredpar Awaiting requested review from jaredpar

@simo5 simo5 Awaiting requested review from simo5

@dagood dagood Awaiting requested review from dagood

@dbenoit17 dbenoit17 Awaiting requested review from dbenoit17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qmuntal @ueno @derekparker